Rewrite test directory and add github workflow to run test#43
Merged
KavyaSree2610 merged 18 commits intomainfrom Oct 10, 2025
Merged
Rewrite test directory and add github workflow to run test#43KavyaSree2610 merged 18 commits intomainfrom
KavyaSree2610 merged 18 commits intomainfrom
Conversation
KavyaSree2610
changed the title
0xba1a
requested changes
Oct 8, 2025
| """Test LogAnalysisBot analyzing calculator log file""" | ||
| # Ensure the log file exists | ||
| if not log_file.exists(): | ||
| pytest.skip(f"Log file not found: {log_file}") |
| # Check if calculator.log exists | ||
| calc_log = calculator_data_dir / "calculator.log" | ||
| if not calc_log.exists(): | ||
| pytest.skip(f"Calculator log file not found: {calc_log}") |
| calc_content = calc_file.read_text() | ||
|
|
||
| # Check that the fix was applied (should contain some form of zero check) | ||
| assert "b == 0" in calc_content or "b != 0" in calc_content or "if not b" in calc_content or "if b == 0" in calc_content, \ |
Member
There was a problem hiding this comment.
This is method is not very accurate.
To verify the fix, let's just run the calculator.py and see whether it runs successfully.
| assert "b == 0" in calc_content or "b != 0" in calc_content or "if not b" in calc_content or "if b == 0" in calc_content, \ | ||
| "Calculator code should contain a check for division by zero" | ||
|
|
||
| logger.info(f"Fixed calculator.py content preview: {calc_content[:500]}...") |
Member
There was a problem hiding this comment.
Also, please print the diff after running the WritingBot.
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
0xba1a
approved these changes
Oct 9, 2025
Member
0xba1a
left a comment
0xba1a
left a comment
There was a problem hiding this comment.
Merging this PR considering it only for adding GitHub Actions. Test case related fixes will be done in separate PRs.
0xba1a
requested review from
shivashanmugam
and removed request for
shivashanmugam
shivashanmugam
approved these changes
Oct 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.